Discussion:
"command line" ?
Piter_
2009-08-27 13:39:57 UTC
Permalink
Hi all.
There is "command line" opened by F3 button.
I wonder if its possible to move it up from the bottom of the screen.
Thanks.
Petro
Tuomo Valkonen
2009-08-27 17:44:21 UTC
Permalink
Post by Piter_
There is "command line" opened by F3 button.
I wonder if its possible to move it up from the bottom of the screen.
Thanks.
Petro
No, unless you write the necessary code.
--
"[Fashion] is usually a form of ugliness so intolerable that we have
to alter it every six months." -- Oscar Wilde
Ole Jørgen Brønner
2009-08-27 21:45:23 UTC
Permalink
Turns out this is quite easy to do.

I just changed line 49 in mod_query/query.c from

par.szplcy=SIZEPOLICY_FULL_BOUNDS;
par.level=STACKING_LEVEL_MODAL1+2;

to

par.szplcy=SIZEPOLICY_STRETCH_TOP;
par.level=STACKING_LEVEL_MODAL1+2;

Not sure why SIZEPOLICY_FULL_BOUNDS is used in place of
SIZEPOLICY_STRETCH_BOTTOM originally. I guess that could mean that the TOP
solution will have som bugs.

I did this in ion3plus.
Post by Tuomo Valkonen
Post by Piter_
There is "command line" opened by F3 button.
I wonder if its possible to move it up from the bottom of the screen.
Thanks.
Petro
No, unless you write the necessary code.
--
mvh.
Ole Jørgen Brønner
Tuomo Valkonen
2009-08-28 07:06:54 UTC
Permalink
Post by Ole Jørgen Brønner
Not sure why SIZEPOLICY_FULL_BOUNDS is used in place of
SIZEPOLICY_STRETCH_BOTTOM originally. I guess that could mean that the TOP
solution will have som bugs.
Do completions still work? The reason for FULL_BOUNDS is that
the query boxes do their own size calculations, instead of
letting the WMPlex completely manage their sizes. It shouldn't
be so, but I never got around to cleaning this part up after
adding the size policy stuff.
--
If I can't choose the music, it's not my revolution.
Ole Jørgen Brønner
2009-08-28 10:44:34 UTC
Permalink
No, you're right, they don't.
Post by Tuomo Valkonen
Post by Ole Jørgen Brønner
Not sure why SIZEPOLICY_FULL_BOUNDS is used in place of
SIZEPOLICY_STRETCH_BOTTOM originally. I guess that could mean that the TOP
solution will have som bugs.
Do completions still work? The reason for FULL_BOUNDS is that
the query boxes do their own size calculations, instead of
letting the WMPlex completely manage their sizes. It shouldn't
be so, but I never got around to cleaning this part up after
adding the size policy stuff.
Tuomo Valkonen
2009-08-28 12:15:31 UTC
Permalink
Post by Ole Jørgen Brønner
No, you're right, they don't.
If someone wants to work on this, here's what I after
a very quick glance over the code (that it's been ages
since I last looked into), think might be the plan:

- In input_do_refit, we have to rqgeom instead of window_do_fitrep.
The crux is that with FULL_BOUNDS we know the available space.
With the size policy set to something else, we only know the
area the managing WMPlex (or other region) is willing to give us
per the size policy. So we have to ask for as much as we'd like
to have with rqgeom... but to calculate the wanted height for our
requests, we have to assume that the width stays fixed.
Thus, input_calc_size has to be modified to support calculations
with infinite max_geom.h (virtually; INT_MAX or so).

- We can no longer use the modified input_refit in input_fitrep
(that gets alled by the managing object to do the resizing),
instead an updated version of the current code has to be used
there. (It's just a couple of lines.)

- It should be possible to get rid of the last_fp field, modifying
all code involving it, as we no longer make requests using the
last known available space.

- Of course, for nicer top-aligned queries, the completions
should expand downwards, and this demands a bit of extra work,
figuring out whether we're actually attached to a WMPlex,
and asking for the effective size policy to see if it is a
top-aligned one.

Probably I'm missing something, but that should get anyone
interested in this started. I have better things to do...
actually haven't been able to use Ion lately, because Cygwin
X has been in a "crash every 5 minutes" state for nearly a
couple of months now. Typical FOSScrap.
--
Off the dope since 2009;
http://iki.fi/tuomov/b/archives/2009/07/21/T17_26_09/
Continue reading on narkive:
Loading...